HipChatAgent: username length limit is 15 chars

Also try to use travis-cis bundle caching

Dominik Sander 9 年之前
父节点
当前提交
daca2fd7b6
共有 3 个文件被更改,包括 4 次插入4 次删除
  1. 1 1
      .travis.yml
  2. 1 1
      app/models/agents/hipchat_agent.rb
  3. 2 2
      spec/models/agents/hipchat_agent_spec.rb

+ 1 - 1
.travis.yml

@@ -1,6 +1,6 @@
1 1
 language: ruby
2
+bundler_args: --without development production --deployment
2 3
 cache: bundler
3
-bundler_args: --without development production
4 4
 env:
5 5
   - APP_SECRET_TOKEN=b2724973fd81c2f4ac0f92ac48eb3f0152c4a11824c122bcf783419a4c51d8b9bba81c8ba6a66c7de599677c7f486242cf819775c433908e77c739c5c8ae118d
6 6
 rvm:

+ 1 - 1
app/models/agents/hipchat_agent.rb

@@ -43,7 +43,7 @@ module Agents
43 43
       client = HipChat::Client.new(interpolated[:auth_token] || credential('hipchat_auth_token'))
44 44
       incoming_events.each do |event|
45 45
         mo = interpolated(event)
46
-        client[mo[:room_name]].send(mo[:username], mo[:message], :notify => boolify(mo[:notify]), :color => mo[:color])
46
+        client[mo[:room_name]].send(mo[:username][0..14], mo[:message], :notify => boolify(mo[:notify]), :color => mo[:color])
47 47
       end
48 48
     end
49 49
   end

+ 2 - 2
spec/models/agents/hipchat_agent_spec.rb

@@ -17,7 +17,7 @@ describe Agents::HipchatAgent do
17 17
 
18 18
     @event = Event.new
19 19
     @event.agent = agents(:bob_weather_agent)
20
-    @event.payload = { :room_name => 'test room', :message => 'Looks like its going to rain', username: "Huggin user"}
20
+    @event.payload = { :room_name => 'test room', :message => 'Looks like its going to rain', username: "Huggin user                  "}
21 21
     @event.save!
22 22
   end
23 23
 
@@ -53,7 +53,7 @@ describe Agents::HipchatAgent do
53 53
   describe "#receive" do
54 54
     it "send a message to the hipchat" do
55 55
       any_instance_of(HipChat::Room) do |obj|
56
-        mock(obj).send(@event.payload[:username], @event.payload[:message], {:notify => false, :color => 'yellow'})
56
+        mock(obj).send(@event.payload[:username][0..14], @event.payload[:message], {:notify => false, :color => 'yellow'})
57 57
       end
58 58
       @checker.receive([@event])
59 59
     end